Bump bazel to 0.26.1 #407
Merged
Bump bazel to 0.26.1 #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
cryslith
reviewed
Sep 4, 2019
build-chroot/bump-pinned-bazel.sh
Outdated
|
|
||
| curl -L -o "bazel-${VERSION}.deb" "https://github.com/bazelbuild/bazel/releases/download/${VERSION}/bazel_${VERSION}-linux-x86_64.deb" | ||
| curl -L -o "bazel-${VERSION}.deb.sig" "https://github.com/bazelbuild/bazel/releases/download/${VERSION}/bazel_${VERSION}-linux-x86_64.deb.sig" | ||
| gpg --no-default-keyring --keyring ./bazel-keyring.gpg --trust-mode=always --verify "bazel-${VERSION}.deb.sig" |
There was a problem hiding this comment.
script refers to files bazel-keyring.gpg and install-bazel.sh which only works when run from this directory. Also might consider downloading temporary files to a tmpdir so that they don't clutter the working directory if verification fails. See debian-checksum.sh for how I did this for debian
This uses the key downloaded previously (that we just removed) but converted into a keyring to be more readily usable. This script automatically grabs the sha256 hash based on checking a signature, and updates the install-bazel.sh script to include the new version.
We want to follow as closely as possible to upstream.
Multiple changes rolled out to Bazel break our compatibility with the latest version: - bazelbuild/bazel#5817 - bazelbuild/bazel#5818 - bazelbuild/bazel#5825 Update our version of zip_file to be compatible with these changes.
An upgrade to upstream bazel exposed an error in one of our BUILD files: - bazelbuild/bazel#7513
For the sake of clarity, segment the directives in WORKSPACE into neater blocks of code.
This is part of ensuring that we're compatible with the latest bazel. Add additional dependencies on components no longer included in rules_go.
We want to follow as closely as possible to upstream.
celskeggs
force-pushed
the
temp-refactor-404
branch
from
b1db00c
to
d302b1c
Compare
|
@cryslith: re-review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a set of changes, partially pulled out of @cryslith's work in #404, which make it possible to build with Bazel 0.26.1. Bumping to bazel 0.27.2 is not possible at this time, for the reason shown in #404, where containerregistry has a bug that affects us, so we're just going up to this version.
I'm not certain all of the changes I pulled out are strictly necessary for 0.26.1, but they're all good changes to have, so we may as well include them now.
Checklist: